is there a way to show how it looks like maybe a link or copy to the comment ?
is a library to use?

https://gist.github.com/JBlond/2fea43a3049b38287e5e9cefc87b2124

add a helper func to Format the text

we have a style package
style.Enable(.....)

we should have a style func that does
style.Normal( white color)
style.Enabled(
Style.Trouble(

this should be an iteration loop that calls the and based on the status it will call the Style Function in the package.

This is green forground color. I will help to add a comment like:

Enabled = "033円[32m" // green forground

This is not a color but a reset command, removing all attributes (foreground color, background color, effects). We don't need a constant for default since it does not change the text.

Same, since this is using the same value as default.

This is red foreground, a comment will help.

But I don't think this is the way to go. What we need is a new package for color that can be reused by code writing output for tables or other output.

This package can use constants to the define the color of enabled, disabled, or errors, and provide functions using this signature:

Enabled(s string) string

Code rendering UI should use the functions to decorate fragments of text.

To implement this we can use a library like this:
https://github.com/fatih/color?tab=readme-ov-file#insert-into-noncolor-strings-sprintfunc

The advantage of using a library is using a well tested code that works on all platforms.

We don't need to update the dates, that's pointless effort. The best way is to remove the date form the copyright headers, but this is not in the scope of this PR, so just remove this change.

This is too complicated for no reason.

Converting the values to string like we did before was better. If we colorize all value in a raw, we can keep the old code as is and apply the right color function to the entire slice.

Why did you change this?

We have 3 logic changes:

• Removing the profile column
• Replacing Status with Enabled
• Coloring the output

Each change should be done in a separate commit. This will make it easier to write the code without errors, test it, and review.

Too complicated.

We need 2 steps:

• Create list of strings for the table writer
• Color the strings

For creating list of strings we can modify the previous code a little bit:

enabled := addonBundle.IsEnabled(cc)
row = []string{addonName, cc.Name, iconFromStatus(enabled), maintainer}

iconForStatus() should return empty string if enabled is false. If it does not do this create a function that does this.

Since the list is so simple, we don't really need a loop to color it:

if enabled {
 row[0] = color.Enabled(row[0])
 row[2] = color.Enabled(row[2])
}

But since wan to color longer lists (like profile list), we can add a function to color rows:

type colorFunc func(string) string
func ColorRow(row []string, colored colorFunc) {
 for i := range row {
 text := row[i]
 if text == "" || isEmoji(text) {
 continue
 }
 row[i] = colored(text)
 }
}

With this we can do:

switch status {
case Broken:
 color.ColorRow(row, color.Broken)
case Error:
 color.ColorRow(row, color.Error)
case Enabled:
 color.ColorRow(row, color.Enabled)
}

I don't think this change is needed or relevant to the PR. Other files follow the same convention. So this should be taken care of in a different PR for refactoring once its determined why its being done this way. I think this is done to make the function easier to test but I'm not sure.

hi @Wilson-Duncan here is the output of the and correcting your above comment
image
image
image

I'm saying the commands should not be in the screenshots. ./out/minikube profile list, make, ./out/minikube addons list, and ./out/minikube profile list -d should be plain text and not a part of the screenshot.

table.Options(tablewriter.WithHeaderAutoFormat(tw.On)) replaces this code?

Is this related to the color change? If not please don't include this in this PR. I'm trying to review the color changes and I don't have time to review other changes now.

Why did you change these names? Is this related to the color changes?

Why to you keep adding unrelated whitespace changes? I already commented about it in previous reviews several times.

Lets move the helpers to another file since they are used both in adding_list.go and profile_list.go. We can add a color.go file for these helpers. If we use colors only in the config package this is good enough for now, but I think the best place for it is a new color package in pkg/minikube/color/color.go.

This will not color test with emoji like "enabled ✅". Currently we don't have this but it will be more correct to use:

s == "✅"

Ideally we can use the unicode package to detect if the string contains only emoji characters.