Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: check for None before rendering nav items #6454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@linkvt linkvt commented Oct 16, 2025

Fixes #6453

Proposed Changes

  • Check if navbar items is defined before trying to render them

fyi @evankanderson

Copy link

netlify bot commented Oct 16, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 730411d
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68f100f2b0b71500083d5922
😎 Deploy Preview https://deploy-preview-6454--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2025
Copy link
Member

/lgtm
/approve
linkvt reacted with heart emoji

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
Copy link

knative-prow bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson , linkvt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • (削除) OWNERS (削除ここまで) [evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@knative-prow knative-prow bot merged commit acc02b4 into knative:main Oct 16, 2025
19 checks passed
@linkvt linkvt deleted the add-none-check-for-sidebar-nav-items branch October 16, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@skonto skonto Awaiting requested review from skonto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Local docs build failing due to undefined nav items

AltStyle によって変換されたページ (->オリジナル) /