-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: mount propagation documentation in feature flags #6223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @elijah-rou! It looks like this is your first PR to knative/docs 🎉
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we undo the formatting that's not related to the feature flag you're adding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the prior indent is intentional - otherwise the note block doesn't render properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't want this change - we're just using ... to elide the metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise above
hey @elijah-rou just following up on this
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: elijah-rou
Once this PR has been reviewed and has the lgtm label, please ask for approval from dprotaso. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@elijah-rou any chance you could address these docs changes?
@elijah-rou just following up here
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Sorry about the merge -- in #6398 , I moved all the versioned documentation under versioned, to separate it from the blog, testimonials, community pages that are not version-specific. You should be able to just move these files to the new location; I didn't need to change any contents.
Adds mountPropagation to the features/extensions page. For knative/serving#15758