Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update code-block-buttons.js #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arun7677 wants to merge 1 commit into keploy:main
base: main
Choose a base branch
Loading
from Arun7677:Arunangshu-Mazumdar

Conversation

Copy link

@Arun7677 Arun7677 commented Jun 20, 2025
edited
Loading

  • Replaced innerHTML with template literals to prevent XSS vulnerabilities
  • Switched to DOMContentLoaded event for earlier script execution
  • Improved accessibility and user feedback for clipboard copy buttons
  • Added error handling for clipboard failures
  • Prevented duplicate buttons and improved memory management

What has changed?

Please include a summary of the change.

This PR Resolves #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update (if none of the other choices apply).

How Has This Been Tested?

Please run npm run build and npm run serve to check if the changes are working as expected. Please include screenshots of the output of both the commands. Add screenshots/gif of the changes if possible.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

- Replaced innerHTML with template literals to prevent XSS vulnerabilities
- Switched to DOMContentLoaded event for earlier script execution
- Improved accessibility and user feedback for clipboard copy buttons
- Added error handling for clipboard failures
- Prevented duplicate buttons and improved memory management
Signed-off-by: Arunangshu Mazumdar <amazumdar41@gmail.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link
Contributor

@pratik-mahalle pratik-mahalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Arun7677, Thank you for raising the pr. Our team will review the changes soon

Copy link
Member

Hey @Arun7677 Thanks for raising this PR, can you please provide a preview/video for the same, I just want to make sure that the UI looks nice and nothing is breaking on the front end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@pratik-mahalle pratik-mahalle pratik-mahalle left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /