-
Notifications
You must be signed in to change notification settings - Fork 5.4k
AMI hotfix #4739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMI hotfix #4739
Conversation
...f this is the default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Is the dir egs/ami/s5c_apt2141 supposed to be added? I would have thought you'd submit just your fixes? There are things like MANIFEST.txt that don't look like they should be added, too..
Oops! Yup, I meant to only push a subset of the changes here. (It was packaged in this state for the course I did this project for). Let's delete this PR and I'll make a new one later this week with just the relevant fixes.
This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open.
There's a couple issues with egs/ami (broken URLs, missing call to generate x-vector, etc). As part of a class at Columbia University, I worked out of that directory and cleaned up some of those dependencies. The corrections should become part of egs/ami for posterity.