Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make Marshal(RawMessage) behave like encoding/json #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greensea wants to merge 1 commit into json-iterator:master
base: master
Choose a base branch
Loading
from greensea:patch-1

Conversation

@greensea
Copy link

@greensea greensea commented Jul 14, 2020

In encoding/json, there is MarshalJSON() and UnmarshaslJSON() for RawMessage. Missing this two method leads to different behavior while Marshal() jsoniter.RawMessage using std json package.

Example code below

package main
import (
 "fmt"
 "encoding/json"
 "github.com/json-iterator/go"
)
type T struct {
 Msg jsoniter.RawMessage
}
func main() {
 var j T
 
 raw := []byte(`{ "Msg": {"Foo": "Bar"}}`)
 
 jsoniter.Unmarshal(raw, &j)
 
 b1, _ := json.Marshal(j.Msg)
 fmt.Printf("%s\n", b1) /// Expect `{"Foo": "Bar"}` but got `"IHsiRm9vIjogIkJhciJ9"`
 
 b2, _ := jsoniter.Marshal(j.Msg)
 fmt.Printf("%s\n", b2)
}

In encoding/json, there is MarshalJSON() and UnmarshaslJSON() for RawMessage. Missing this two method leads to different behavior while Marshal() jsoniter.RawMessage using std json package.
Example code below
```
package main
import (
 "fmt"
 "encoding/json"
 "github.com/json-iterator/go"
)
type T struct {
 Msg jsoniter.RawMessage
}
func main() {
 var j T
 
 raw := []byte(`{ "Msg": {"Foo": "Bar"}}`)
 
 jsoniter.Unmarshal(raw, &j)
 
 b1, _ := json.Marshal(j.Msg)
 fmt.Printf("%s\n", b1) /// Expect `{"Foo": "Bar"}` but got `"IHsiRm9vIjogIkJhciJ9"`
 
 b2, _ := jsoniter.Marshal(j.Msg)
 fmt.Printf("%s\n", b2)
}
```
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #474 into master will decrease coverage by 0.50%.
The diff coverage is 22.22%.

Impacted file tree graph

@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 86.64% 86.14% -0.51% 
==========================================
 Files 41 41 
 Lines 5100 5109 +9 
==========================================
- Hits 4419 4401 -18 
- Misses 540 566 +26 
- Partials 141 142 +1 
Impacted Files Coverage Δ
adapter.go 81.15% <22.22%> (-8.85%) ⬇️
reflect_struct_decoder.go 82.68% <0.00%> (-2.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ca083...6f96243. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /