-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make Marshal(RawMessage) behave like encoding/json #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In encoding/json, there is MarshalJSON() and UnmarshaslJSON() for RawMessage. Missing this two method leads to different behavior while Marshal() jsoniter.RawMessage using std json package.
Example code below
```
package main
import (
"fmt"
"encoding/json"
"github.com/json-iterator/go"
)
type T struct {
Msg jsoniter.RawMessage
}
func main() {
var j T
raw := []byte(`{ "Msg": {"Foo": "Bar"}}`)
jsoniter.Unmarshal(raw, &j)
b1, _ := json.Marshal(j.Msg)
fmt.Printf("%s\n", b1) /// Expect `{"Foo": "Bar"}` but got `"IHsiRm9vIjogIkJhciJ9"`
b2, _ := jsoniter.Marshal(j.Msg)
fmt.Printf("%s\n", b2)
}
```
Codecov Report
@@ Coverage Diff @@ ## master #474 +/- ## ========================================== - Coverage 86.64% 86.14% -0.51% ========================================== Files 41 41 Lines 5100 5109 +9 ========================================== - Hits 4419 4401 -18 - Misses 540 566 +26 - Partials 141 142 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In encoding/json, there is MarshalJSON() and UnmarshaslJSON() for RawMessage. Missing this two method leads to different behavior while Marshal() jsoniter.RawMessage using std json package.
Example code below