Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add support for Zsh #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jefferson-Faseler wants to merge 8 commits into jordanwilson230:master
base: master
Choose a base branch
Loading
from Jefferson-Faseler:zsh-ize

Conversation

Copy link

@Jefferson-Faseler Jefferson-Faseler commented Oct 9, 2020

Branch off of #10
Couldn't target branch in @jordanwilson230's repo and didn't want to make @grzesuav the middleman.

Checklist

  1. Addresses Issue: Make kubectl-prompt suitable for use with zsh #9
  2. Instead of dependencies on the ~/.bash_profile throughout the code, the scripts can dynamically interpolate the shell profile. As of now support is Zsh and bash as the default.
  3. Changes are GNU/BSD Compatible
  4. Changes are applicable to the wider community.: I believe this is covered by the feature request.
  5. Request help with testing if needed.
    I tested against prompt and it's family of sub-commands and flags, as well as image.

Copy link
Owner

@Jefferson-Faseler @grzesuav thanks for contributing! I see you were able to test against the prompt and image plugins but wanted to ask if anyone would be able to test the ssh plugin as well?

Copy link
Owner

jordanwilson230 commented Oct 20, 2020 •
edited
Loading

@Jefferson-Faseler @grzesuav What do you think about just moving the zsh stuff into its own branch and putting linking it in the readme. Would you be ok if I put your changes in a zsh branch?

Copy link
Author

Let me do a bit more testing on it. Had some odd warnings from when I jumped to a bash env earlier today from zsh and want to make sure it wasn't from the way I'm doing something here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /