-
-
Notifications
You must be signed in to change notification settings - Fork 695
Fix weird transition #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DiegoArenaO
wants to merge
2
commits into
jonkykong:master
from
DiegoArenaO:fix-weird-transition-#656
Open
Fix weird transition #660
DiegoArenaO
wants to merge
2
commits into
jonkykong:master
from
DiegoArenaO:fix-weird-transition-#656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the fix of the PR jonkykong#650 by @2h4u to fix the weird transition opening the app. Adding the inactive case will fix the weird transition when the device is rotated
I reverted the changes made by #642 since it looks like they only fixed the symptoms but not the root cause of the problem. The SideMenuAnimationController can not operate as indented without a presentationController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the fix of the PR #650 by @2h4u to fix the weird transition opening the app.
Adding the inactive case will fix the weird transition when the device is rotated