-
Notifications
You must be signed in to change notification settings - Fork 268
boxcli: add clean command #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I added the hard flag now to also delete the devbox.json file, I don't quite like the naming yet and am open for suggestions
trya2l
commented
Oct 11, 2024
Hi, what about --all, or --force ?
All might be an option. Imo force is something else, it means perform an action even though it might break things, an doesn't fit the action here.
How about devbox uninit or devbox eject?
A command named clean deleting devbox.json and devbox.lock would be very surprising to me.
Uh oh!
There was an error while loading. Please reload this page.
Summary
This if a first draft for #2335, I am not sure about the behaviour or features of the command yet so I only added basic functionality.
The issue also mentioned deleting files like .envrc, I didn't include this yet since these files might be generated by a user instead of the devbox, maybe this should be added by an optional parameter? or are generated files tracked?
I also wasn't sure if the clean command should exit the devbox shell or not. In case it should, is the pid of the devbox saved anywhere so it can be killed, or is there a better way to do so?
How was it tested?
=> expected result: .devbox, devbox.lock are deleted and the user remains in the shell.
I also included a test, but I can't test it because of #2342 so it might fail.
Edit
The behaviour is as following now:
running
devbox cleandeletes .devbox and devbox.lockrunning
devbox clean --hardasks for a confirmation and also deletes devbox.json