-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add Support for rocm57 required by some AMD GPU #7531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
linux-universe
commented
Apr 9, 2025
anything holding this back?
@en0
en0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying similar fixes locally and noticed you had a couple typeos in this mr
@en0
en0
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be groupadd -g ${VIDEO_GID} video
@en0
en0
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although this will likely work as is, it is more correct to do usermod -aG video $USER
Summary
Add support for rocm57 required by some AMD GPU, For example my RX 7600 XT
fix /dev/kfd and /dev/dri/card0 ownership when required
fix a small issue of extra \n in docker/run.sh
Related Issues / Discussions
may fix bug #4211 when using docker/run.sh
Merge Plan
I took care not to provoke regression by adding a new rocm57 profile
Checklist
-[x] The PR has a short but descriptive title, suitable for a changelog
-[x] _Documentation added / updated in .env.sample