feat(expo): enhances notification config retrieval #8663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

huextrat wants to merge 3 commits into invertase:main

from huextrat:feat/expo-notifications

Open

feat(expo): enhances notification config retrieval #8663

huextrat wants to merge 3 commits into invertase:main from huextrat:feat/expo-notifications

+201 −60

Conversation

huextrat

Copy link

@huextrat huextrat commented Aug 21, 2025 •

edited

Loading

Description

Expo 54 will deprecate the use of notification in expo config in favor of expo-notifications expo plugin : https://docs.expo.dev/versions/v54.0.0/config/app/#notification

Improves notification configuration by first checking expo-notifications plugin for icon and color.

Falls back to deprecated config.notification settings. Warns about missing notification icon for Android.

Related issues

fixes: #8664

Release Summary

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
- Yes
My change supports the following platforms;
- Android
- iOS
- Other (macOS, web)
My change includes tests;
- e2e tests added or updated in packages/\*\*/e2e
- jest tests added or updated in packages/\*\*/__tests__
I have updated TypeScript types that are affected by my change.
This is a breaking change;
- Yes
- No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

👉 Star this repo on GitHub ⭐️
👉 Follow React Native Firebase and Invertase on Twitter

@vercel Vercel

Copy link

vercel bot commented Aug 21, 2025 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
react-native-firebase	Ready Ready	Preview	Comment	Sep 23, 2025 3:42pm

@CLAassistant

Copy link

CLAassistant commented Aug 21, 2025 •

edited

Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot deployed to Preview

August 21, 2025 11:59

View deployment

@github-actions GitHub Actions

Copy link

github-actions bot commented Sep 18, 2025

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions bot added the Stale label

Sep 18, 2025

@huextrat

Copy link

Author

huextrat commented Sep 18, 2025

Ping @mikehardy - @MichaelVerdon to get your opinion on this

@github-actions github-actions bot added Needs Attention and removed Stale labels

Sep 18, 2025

@mikehardy

Copy link

Collaborator

mikehardy commented Sep 23, 2025

just closing and reopening to make sure CI runs, it appears to be hung for some reason

@mikehardy mikehardy closed this

Sep 23, 2025

@mikehardy mikehardy reopened this

Sep 23, 2025

huextrat added 2 commits

September 23, 2025 15:25

@huextrat


 feat(expo): enhances notification config retrieval

c6a7418

Improves notification configuration by first checking
`expo-notifications` plugin for icon and color.
Falls back to deprecated `config.notification` settings.
Warns about missing notification icon for Android.

@huextrat