This repository was archived by the owner on Mar 27, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 161
fix: Docker warning when using frapsoft/openssl on arm64 system #3374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DRK3
DRK3
force-pushed
the
ResolveDockerWarningOpenSSLARM
branch
from
September 15, 2022 20:51
80a264c to
a9798a4
Compare
Codecov Report
@@ Coverage Diff @@ ## main #3374 +/- ## ========================================== - Coverage 87.57% 87.56% -0.01% ========================================== Files 343 343 Lines 46809 46832 +23 ========================================== + Hits 40994 41010 +16 - Misses 4318 4323 +5 - Partials 1497 1499 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@fqutishat
fqutishat
force-pushed
the
ResolveDockerWarningOpenSSLARM
branch
from
September 27, 2022 22:02
a9798a4 to
6a9c348
Compare
@DRK3
DRK3
force-pushed
the
ResolveDockerWarningOpenSSLARM
branch
2 times, most recently
from
October 4, 2022 20:11
ef72835 to
55fa969
Compare
@rolsonquadras Can you merge? The unit test failure appears to be some intermittent failure happening in AFGo.
@DRK3
DRK3
force-pushed
the
ResolveDockerWarningOpenSSLARM
branch
from
October 26, 2022 20:25
55fa969 to
ded7f57
Compare
Resolved a warning from Docker that would get printed when running the generate-test-keys Makefile target on an arm64 system. The warning from Docker alerts you that the image for frapsoft/openssl is for amd64, which doesn't match the system you're on (when using an arm64-based OS). To resolve the warning, you have to either use an image that matches the system architecture, or explicitly state the platform using the --platform flag. In this case, there is only an amd64 version of frapsoft/openssl, so I added the explicit flag to resolve the warning. I also added a TODO for us to find an arm64 alternative in the future (although the amd64 version of frapsoft/openssl does work fine on arm64 macOS currently as it seems that Docker makes use of QEMU to support emulation of non-native architectures). Signed-off-by: Derek Trider <Derek.Trider@securekey.com>
@DRK3
DRK3
force-pushed
the
ResolveDockerWarningOpenSSLARM
branch
from
November 1, 2022 20:16
ded7f57 to
7ccc688
Compare
sudeshrshetty
sudeshrshetty
approved these changes
Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Resolved a warning from Docker that would get printed when running the generate-test-keys Makefile target on an arm64 system. The warning from Docker alerts you that the image for frapsoft/openssl is for amd64, which doesn't match the system you're on (when using an arm64-based OS). To resolve the warning, you have to either use an image that matches the system architecture, or explicitly state the platform using the --platform flag. In this case, there is only an amd64 version of frapsoft/openssl, so I added the explicit flag to resolve the warning. I also added a TODO for us to find an arm64 alternative in the future (although the amd64 version of frapsoft/openssl does work fine on arm64 macOS currently as it seems that Docker makes use of QEMU to support emulation of non-native architectures).
Signed-off-by: Derek Trider Derek.Trider@securekey.com