-
Notifications
You must be signed in to change notification settings - Fork 121
fix: calculate burnchain reward reorgs correctly #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vercel deployment URL: https://stacks-blockchain-gdobbf746-hirosystems.vercel.app 🚀
Codecov Report
✅ All modified and coverable lines are covered by tests.
📢 Thoughts on this report? Let us know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I currently am testing the migration and how long it takes to finish in dev. The writer pod gets killed after an hour like you said, but I think it's because Istio is cutting off the connection rather than postgres. Upon restart of the writer, it crashes again saying a migration is already running, and I've confirmed this via PGHero. So it seems like Istio killing the connection and causing the writer to crash may be ok, since the migration continues.
I'll continue monitoring its progress, this will likely be a upgrade deployed next week.
Uh oh!
There was an error while loading. Please reload this page.
Burnchain reward re-orgs were being calculated incorrectly based on old Stacks 2.x logic that no longer applies after 3.x. This was causing some rewards to disappear from our endpoints after being marked as non-canonical.