-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Items support on OpenAPI V2 Responses #3026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
11247b1
to
3207a66
Compare
Before I went any further adding tests / docs I wanted to get your thoughts on this one @johanbrandhorst 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Chris, thanks for the PR! I understand we already allow users to specify custom responses, but this now adds the ability to specify a custom response where the outermost type is an array, is that correct? If so, this isn't so much about how this feature interacts with the disable_default_responses
feature, but rather just about adding this functionality, correct? If so, should we rewrite the proto file comment to focus more on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we shouldn't just make this 19 and hoist it up to the comment above?
Uh oh!
There was an error while loading. Please reload this page.
Feature 🚀
Adds support for array
items
on Open API V2 response objects. This is currently not supported whendisable_default_responses
istrue
.This allows users to define array response objects, for example:
This will generate the following
yaml
whendisable_default_responses=true
See examples here on the OpenAPI V2 spec page.
TODO