Skip to content

Navigation Menu

Sign in
Sign up

chore: add ProGuard rules for this library - #1093

Open
Goooler wants to merge 3 commits into
googleapis:main from
Goooler:proguard-rules
Open

chore: add ProGuard rules for this library #1093
Goooler wants to merge 3 commits into
googleapis:main from
Goooler:proguard-rules

Conversation

@Goooler

@Goooler Goooler commented Dec 14, 2023

Copy link
Copy Markdown

Add ProGuard/R8 keep rules to ensure this lib will be compatible with obfuscation enabled, the files under src/main/resources/META-INF/proguard should be interpreted by R8 automatically.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Goooler requested review from a team December 14, 2023 02:37
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Dec 14, 2023
Add ProGuard/R8 keep rules to ensure this lib will be compatible with obfuscation enabled, the files under `src/main/resources/META-INF/proguard` should be interpreted by R8 automatically.
@Goooler Goooler changed the title (削除) Add ProGuard rules for this library (削除ここまで) (追記) chore: add ProGuard rules for this library (追記ここまで) Dec 14, 2023

Goooler commented Dec 14, 2023

Copy link
Copy Markdown
Author

Actually, we can just keep a few classes under com.google.api.client.auth instead of all of them, but I have no more time to investigate that.

meltsufin requested a review from a team May 23, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meltsufin meltsufin Awaiting requested review from meltsufin

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /