Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(node): pino child loggers #17934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timfish wants to merge 21 commits into develop
base: develop
Choose a base branch
Loading
from timfish/fix/pino-child-loggers
Open

Conversation

Copy link
Collaborator

@timfish timfish commented Oct 14, 2025
edited
Loading

This PR:

  • Includes bindings from child loggers as attributes
  • Tests that track/untrack setting is propagated to child loggers

Copy link
Contributor

github-actions bot commented Oct 14, 2025
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.64 kB - -
@sentry/browser - with treeshaking flags 23.14 kB - -
@sentry/browser (incl. Tracing) 40.99 kB - -
@sentry/browser (incl. Tracing, Replay) 79.29 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.98 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 84 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 96.16 kB - -
@sentry/browser (incl. Feedback) 41.33 kB - -
@sentry/browser (incl. sendFeedback) 29.3 kB - -
@sentry/browser (incl. FeedbackAsync) 34.26 kB - -
@sentry/react 26.35 kB - -
@sentry/react (incl. Tracing) 42.99 kB +0.02% +5 B 🔺
@sentry/vue 29.13 kB - -
@sentry/vue (incl. Tracing) 42.79 kB - -
@sentry/svelte 24.66 kB - -
CDN Bundle 26.94 kB - -
CDN Bundle (incl. Tracing) 41.65 kB - -
CDN Bundle (incl. Tracing, Replay) 77.89 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 83.35 kB - -
CDN Bundle - uncompressed 78.95 kB - -
CDN Bundle (incl. Tracing) - uncompressed 123.53 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 238.54 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 251.31 kB - -
@sentry/nextjs (client) 45.06 kB - -
@sentry/sveltekit (client) 41.42 kB - -
@sentry/node-core 50.78 kB - -
@sentry/node 154.4 kB +0.01% +1 B 🔺
@sentry/node - without tracing 92.65 kB - -
@sentry/aws-serverless 106.35 kB +0.01% +3 B 🔺

View base workflow run

Copy link
Contributor

github-actions bot commented Oct 14, 2025
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,258 - 9,344 -1%
GET With Sentry 1,378 15% 1,412 -2%
GET With Sentry (error only) 6,135 66% 6,130 +0%
POST Baseline 1,196 - 1,211 -1%
POST With Sentry 525 44% 509 +3%
POST With Sentry (error only) 1,073 90% 1,069 +0%
MYSQL Baseline 3,319 - 3,221 +3%
MYSQL With Sentry 429 13% 370 +16%
MYSQL With Sentry (error only) 2,694 81% 2,625 +3%

View base workflow run

cursor[bot]

This comment was marked as outdated.

timfish and others added 14 commits October 15, 2025 13:27
.../sentry-javascript into timfish/fix/pino-child-loggers
...7905)
With 19.2, React introduced [custom perfomance
tracks](https://react.dev/blog/2025/10/01/react-19-2#performance-tracks)
in chrome dev tools. This track is populated by collecting
`performance.measure` entries for every component (re-)render. Sounds
good in theory but in reality this causes a massive performance
degradation when using the Sentry SDK because we collect spans from
`PerformanceMeasure` entries. In our Sentry UI, this caused 10+ second
long blocks because we created thousands of spans from these render
entries.
This patch fixes this performance drop by inspecting the measure entries'
`detail` object which we can use to _fairly well_ distinguish React's
entries from users' entries. Not 100% bulletproof but I think good
enough.
# Summary
This PR adds support for TanStack Router Solid. It follows the same
outline as the existing implementation of TanStack Router React for
Sentry as both TanStack Router flavors are built on the same agnostic
foundation.
---------
Co-authored-by: Andrei Borza <andrei.borza@sentry.io>
next@canary now resolves to next 16 which is why we need to update the
testing strategy here
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #17735
---------
Co-authored-by: andreiborza <168741329+andreiborza@users.noreply.github.com>
This resolves the issue that occurs when an extra `navigation`
transaction is created after a prematurely ended `pageload` transaction
in React Router lazy routes.
This apparently occurs when there's a long-running pageload with
lazy-routes (after fetching assets, there are multiple potentially
long-running API calls happening).
This causes the `pageload` transaction to prematurely end, even before
the fully parameterized transaction name is resolved. The reason is that
there can be a `POP` event emitted, which we subscribe to create a
`navigation` transaction. This ends the ongoing `pageload` transaction
before its name is updated with a resolved parameterized route path, and
starts a `navigation` transaction, which contains the remaining spans
that were supposed to be a part of the `pageload` transaction.
This fix makes sure the initial `POP` events are not necessarily treated
as `navigation` pointers, which should fix both:
- Duplicate / extra `navigation` transactions having a part of
`pageload` spans.
- Remaining wildcards in the `pageload` transaction names
.../sentry-javascript into timfish/fix/pino-child-loggers
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@timfish timfish force-pushed the timfish/fix/pino-child-loggers branch from 88bf3ea to 8eb3787 Compare October 16, 2025 11:25
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seer-by-sentry seer-by-sentry[bot] seer-by-sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /