-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(core): Set span status internal_error instead of unknown_error
#17909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
@Lms24
Lms24
force-pushed
the
lms/ref-core-span-status-internal-error
branch
from
October 16, 2025 09:15
3f632a7 to
dcd9c05
Compare
@Lms24
Lms24
force-pushed
the
lms/ref-core-span-status-internal-error
branch
from
October 16, 2025 12:05
dcd9c05 to
943783c
Compare
@Lms24
Lms24
requested review from
a team,
RulaKhaled,
obostjancic,
s1gr1d and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
October 16, 2025 14:12
obostjancic
obostjancic
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
s1gr1d
s1gr1d
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR refactors almost all occurances of our SDK setting a span status of
unknown_errorto settinginternal_errorinstead. #17814 explains why we do this.I left a few selected occurances of
unknown_errorwhere I think it's fine to not change them. Worth noting, Relay already convertsunknown_errortointernal_error, so this is rather a "cleanup" and only has impact on self-hosted Sentry versions for now.closes #17814