drop media content from MCP message attributes #17864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

naaa760 wants to merge 11 commits into getsentry:develop

from naaa760:msgs-drop-media

Open

drop media content from MCP message attributes #17864

naaa760 wants to merge 11 commits into getsentry:develop from naaa760:msgs-drop-media

Conversation

naaa760

Copy link

@naaa760 naaa760 commented Oct 5, 2025

PR Description

automatically filters out images, videos, audio, and other media content from MCP server message attributes to prevent large media from breaking instrumentation. Tracks dropped media via client reports.

fixes: #17810

Changes:

Added media detection logic for common file types (images, videos, audio, documents)
Filters media content from tool results and prompt results before attribute extraction
Integrates with existing client reports system to track dropped media
Preserves all text content while removing only media items

naaa760 added 3 commits

October 5, 2025 13:57

@naaa760


 new file with media detection and filtering logic

7bd48c1

@naaa760


 updated to filter media from tool and prompt results

526687c

@naaa760


 aded documentation about media dropping behavior

@RulaKhaled RulaKhaled self-requested a review

October 6, 2025 08:38

naaa760 added 8 commits

October 7, 2025 15:31

@naaa760


 update

cccf345

@naaa760


 update

dcbc924

@naaa760


 update

7932dba

@naaa760


 update

f6f5dac

@naaa760


 update

f965f45

@naaa760


 reverted

5bddc4c

@naaa760


 update

28bfcba

@naaa760


 Merge branch 'develop' into msgs-drop-media

d828f59

@naaa760

Copy link

Author

naaa760 commented Oct 7, 2025

@RulaKhaled
let me know, resolve it

cursor[bot]

cursor bot reviewed

Oct 7, 2025

View reviewed changes

packages/core/src/integrations/mcp-server/resultExtraction.ts

const content = message.content;

if (typeof content.text === 'string') {

const attrName = messages.length === 1 ? `${prefix}.message_content` : `${prefix}.content`;

const attrName = filteredMessages.length === 1 ? `${prefix}.message_content` : `${prefix}.content`;

Copy link

@cursor cursor bot Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Undefined Variable Causes Reference Error

A ReferenceError occurs because filteredMessages.length is referenced but filteredMessages is not defined in this scope. It looks like messages.length was the intended variable.

Fix in Cursor Fix in Web