-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Add support for double default values #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add doubleDefaultValue field and doubleFieldDefaultValue() method to Settings - Add double case in ClassDefinition field generation logic - Add UI input field for double default values in JsonInputDialog - Fix existing bugs where bool/int checks used stringFieldDefaultValue() Fixes issue where double fields didn't get default values when 'set default' option was enabled, causing inconsistent behavior compared to other primitive types.
@zhangruiyu
zhangruiyu
merged commit Oct 11, 2025
6d03126
into
fluttercandies:master
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Problem
When using the "set default values" option,
doublefields were not getting default values assigned, causing inconsistent behavior compared to other primitive types (int,bool,String,List).This could lead to:
✅ Solution
Added complete support for
doubledefault values across the entire codebase:Changes Made:
Settings.kt:
doubleDefaultValue: String = "0.0"fielddoubleFieldDefaultValue(): String?methodClassDefinition.kt:
doublecase in field generation logicboolandintchecks incorrectly usedstringFieldDefaultValue()JsonInputDialog.kt:
intandboolfields🧪 Testing
📸 Before vs After
Before:
doublefields had no default valuesAfter:
doublefields get configurable default values (default: "0.0")🔗 Related Issues
Fixes the missing double default value support identified during codebase analysis.