Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Chapter 21 - fix tcp_mojifinder.py crashes on empty search result #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timheiko wants to merge 1 commit into fluentpython:master
base: master
Choose a base branch
Loading
from timheiko:fix-crashes-in-tcp_mojifinder.py

Conversation

@timheiko
Copy link

@timheiko timheiko commented Aug 8, 2025

Fixes #61

Start the TCP server

% ./tcp_mojifinder.py
Building index.
Serving on ('127.0.0.1', 2323). Hit CTRL-C to stop.

Connect to the TCP server and send a search query which return no results and some results, e.g. missing and hat

% nc localhost 2323
?> missing
────────────────────────────────────────────────────────────────── 0 found
?> hat
U+2CD4	Ⳕ	COPTIC CAPITAL LETTER OLD COPTIC HAT
U+2CD5	ⳕ	COPTIC SMALL LETTER OLD COPTIC HAT
U+A271	ꉱ	YI SYLLABLE HAT
U+D571	핱	HANGUL SYLLABLE HAT
U+1F3A9	🎩	TOP HAT
U+1F452	👒	WOMANS HAT
U+1F920	🤠	FACE WITH COWBOY HAT
U+1F973	🥳	FACE WITH PARTY HORN AND PARTY HAT
────────────────────────────────────────────────────────────────── 8 found
?>

The TCP server log contains no errors and doesn't crash the TCP connection:

 % ./tcp_mojifinder.py
Building index.
Serving on ('127.0.0.1', 2323). Hit CTRL-C to stop.
 From ('127.0.0.1', 63756): 'missing'
 To ('127.0.0.1', 63756): 0 results.
 From ('127.0.0.1', 63756): 'hat'
 To ('127.0.0.1', 63756): 8 results.

Fixes fluentpython#61
Start the TCP server
```shell
% ./tcp_mojifinder.py
Building index.
Serving on ('127.0.0.1', 2323). Hit CTRL-C to stop.
```
Connect to the TCP server and send a search query which return no results and some results, e.g. `missing` and `hat`
```shell
% nc localhost 2323
?> missing
────────────────────────────────────────────────────────────────── 0 found
?> hat
U+2CD4	Ⳕ	COPTIC CAPITAL LETTER OLD COPTIC HAT
U+2CD5	ⳕ	COPTIC SMALL LETTER OLD COPTIC HAT
U+A271	ꉱ	YI SYLLABLE HAT
U+D571	핱	HANGUL SYLLABLE HAT
U+1F3A9	🎩	TOP HAT
U+1F452	👒	WOMANS HAT
U+1F920	🤠	FACE WITH COWBOY HAT
U+1F973	🥳	FACE WITH PARTY HORN AND PARTY HAT
────────────────────────────────────────────────────────────────── 8 found
?>
```
The TCP server log contains no errors and doesn't crash the TCP connection:
```
 % ./tcp_mojifinder.py
Building index.
Serving on ('127.0.0.1', 2323). Hit CTRL-C to stop.
 From ('127.0.0.1', 63756): 'missing'
 To ('127.0.0.1', 63756): 0 results.
 From ('127.0.0.1', 63756): 'hat'
 To ('127.0.0.1', 63756): 8 results.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chapter 21 - tcp_mojifinder.py crashes on empty search result

1 participant

AltStyle によって変換されたページ (->オリジナル) /