-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(messaging): macos incorrect parsing of notification response ... #17231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(messaging): macos incorrect parsing of notification response ... #17231
Conversation
...inishLaunchingNotification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, I am sorry I did not see this sooner. It looks alright to me. Can I get you to fix formatting issues that occured on CI? Should be very quick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @MichaelVerdon , I am very sorry, I unfortunately lost sight of your message. I just ran clang-format (see latest commit), so the tests now should pass. Can you approve another test run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelVerdon Ping :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there thanks for the ping @steffenhaak I will be checking this out properly
...in application_onDidFinishLaunchingNotification
Description
See bug report in related issue.
Related Issues
#17230
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?