-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Code Quality: Sync the jump list with Explorer #17564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
71afbb3 to
9eb7ae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code used at all? If not, we can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to put something in place to prevent stale jumplists after updating Files or Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do the same as what we do at the startup, clear all and fetch items from Explorer.
Should we do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the update task run even if Files is closed? In that case, I think we should do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now when the app is updated, the old jump list will be deleted and re-fetched from Explorer.
97999e5 to
806f922
Compare
278a971 to
33efe98
Compare
This might help with #14526
Would this fix #17659
Yes. This is one of the motivation. (I updated the PR to include this)
a038857 to
3669604
Compare
9daefd6 to
032a523
Compare
Uh oh!
There was an error while loading. Please reload this page.
Resolved / Related Issues
TODOs
Steps used to test these changes
- Build the app
- Cold-launch the app
- See its jump list being the same as the Explorer's jump list
- Pin/unpin an item from the Explorer's jump list
- See that of Files also gets updated
- Do the way around of above
image image