-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Code Quality: Fixed HighContrast theme resources #17409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding WinUI brushes across an entire XAML file introduces potential risks and unintended side effects. It would be safer to stick with our previous approach using lightweight styling and apply a custom brush if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to assign the style?
aee8e6e to
0512967
Compare
97999e5 to
806f922
Compare
Resolved / Related Issues
Steps used to test these changes