-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature: Add Everything search & folder size calculation #17336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elliotttate
wants to merge
4
commits into
files-community:main
from
elliotttate:feature/everything-search-folder-size
Open
Feature: Add Everything search & folder size calculation #17336
elliotttate
wants to merge
4
commits into
files-community:main
from
elliotttate:feature/everything-search-folder-size
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Everything search engine integration as an alternative to Windows Search - Implement fast folder size calculation using Everything's indexing - Add settings UI to switch between Windows Search and Everything - Show warning if Everything is not installed with download link - Automatically use Everything for folder sizes when selected as search engine - Add safeguards for large directories to prevent memory issues - Support architecture-aware DLL loading (Everything32.dll/Everything64.dll) - Implement graceful fallback to Windows Search when Everything is unavailable - Add periodic availability checks (every 30 seconds) to detect Everything status - Remove separate toggle for Everything folder sizes - automatic when Everything is enabled 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
src/Files.App/Utils/Storage/Search/EverythingSearchEngineService.cs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
- Implement EverythingSdk3Service for Everything 1.5 integration - Add direct folder size query using Everything3_GetFolderSizeFromFilenameW() - Automatic detection and fallback: SDK3 -> SDK2 -> Windows Search - Update EverythingSearchService to try SDK3 first - Update EverythingSizeProvider to use SDK3 when available - Add proper error handling for missing SDK3 DLLs - Add documentation about SDK3 requirements - SDK3 provides significant performance improvements for folder size calculations Note: SDK3 DLLs must be obtained separately from https://github.com/voidtools/everything_sdk3 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fixes CS0117 compilation error - Toast notification method was not implemented in AppToastNotificationHelper 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Run all folder size calculations on background threads - Add semaphore to limit concurrent calculations to 3 - Add timeout (2s) for SDK3 folder size queries - Fire and forget size calculations during enumeration - Return cached sizes immediately without blocking - Properly dispose resources (semaphore and SDK3 service) This prevents the UI from freezing when navigating folders with Everything folder size calculation enabled. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the log gets spammed and seems unnecessary
2025年07月28日 20:05:53.4383|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025年07月28日 20:05:53.4520|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\DRM removed (0 files)
2025年07月28日 20:05:54.0583|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025年07月28日 20:05:54.0761|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\Program Files (0 files)
2025年07月28日 20:05:54.0871|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025年07月28日 20:05:54.1074|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\Path of Titans (0 files)
2025年07月28日 20:05:54.1578|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025年07月28日 20:05:54.1756|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\Steam (0 files)
2025年07月28日 20:05:54.3140|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025年07月28日 20:05:54.3279|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\Unity Editors (0 files)
2025年07月28日 20:05:55.3815|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025年07月28日 20:05:55.3968|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\WindowsApps (0 files)
There a stack overflow crash (line 292) when in some folders and calculate folder size is enabled using Everything 1.4
image
@Josh65-2201
Josh65-2201
added
the
changes requested
Changes are needed for this pull request
label
Jul 28, 2025
@elliotttate this doesn't seem to work on ARM64.
@yaira2
yaira2
force-pushed
the
main
branch
2 times, most recently
from
September 9, 2025 21:12
97999e5 to
806f922
Compare
@elliotttate this doesn't seem to work on ARM64.
As far as I understand, Alpha still does not support ARM64. But in theory, you can do 1.4.1 versions until 1.5A is available in ARM form.
@elliotttate Are you able to continue on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Closes #5845
Closes #16979
2025年07月28日.10-22-09.mp4