-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Code Quality: Continued working on Shelf Pane #17308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@d2dyno1 thank you for the PR! We're not ready to enable this just yet as I still need to add the resize logic.
- I noticed there are a few new buttons at the bottom of the pane, was this a deliberate change? The original spec had them placed in a context menu, but we never really talked this through. Curious to hear your thoughts.
- Does the file watcher update the list if items are deleted or renamed externally?
Add "View in parent folder" menu option
This is a nice touch 🙂
@d2dyno1 thank you for the PR! We're not ready to enable this just yet as I still need to add the resize logic.
If time allows, I can add the resizing logic in this PR (borrowing it from the preview pane).
- I noticed there are a few new buttons at the bottom of the pane, was this a deliberate change? The original spec had them placed in a context menu, but we never really talked this through. Curious to hear your thoughts.
The buttons were an inspiration from the original spec and I think they can stay for when we roll out the Shelf feature. We can gather feedback on them and the behavior can always be changed in the future. It's not set in stone 🙂
- Does the file watcher update the list if items are deleted or renamed externally?
Yes, the implementation is based on FileSystemWatcher which does observe the changes across the file system.
Add "View in parent folder" menu option
This is a nice touch 🙂
😉 @yaira2
If time allows, I can add the resizing logic in this PR (borrowing it from the preview pane).
That would be great, thanks! Aside from the actual resizing of the pane, there are other behaviors that I need to finalize such as smaller window sizes etc.
Is renaming an item supposed to remove it from the list?
Where do you plan to put the open shelf toggle button?
Where do you plan to put the open shelf toggle button?
It's next to the Status Center button.
Where do you plan to put the open shelf toggle button?
It's next to the Status Center button.
Thats fine, I was going to say we should avoid putting it into the toolbar, as those are kind of scoped to the view panes, and the shelf is separate from those.
97999e5 to
806f922
Compare
Uh oh!
There was an error while loading. Please reload this page.
Resolved / Related Issues
This PR introduces minor changes, unless additional changes are requested. The file watcher was implemented quite some time ago and already works properly, thanks to #16900 and #16728. This PR focuses solely on re-enabling this feature, but can be iterated upon to accommodate any undocumented missing features (if any? - not that I'm aware of)
(削除) Re-enabled the command for showing the Shelf pane in production (削除ここまで)Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.