Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added an overlay for non 0 exit codes. #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ulysse2211 wants to merge 1 commit into dscalzi:master
base: master
Choose a base branch
Loading
from Ulysse2211:non-zero-game-exit-code-overlay

Conversation

Copy link

@Ulysse2211 Ulysse2211 commented May 13, 2024

Added the feature in #23 with a copy button on the overlay to copy the exit code.

Copy link

Kalitsune commented May 13, 2024
edited
Loading

Works great and it makes a really pertinent addition that makes the overall launcher experience more polished

image

Works in every situation even weird ones like having the launcher detached from the main process.

Ulysse2211 reacted with thumbs up emoji

Copy link

@Kalitsune Kalitsune May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo here, the exited code should be the exit code

Ulysse2211 and DarkShoro reacted with thumbs up emoji
Copy link

@Kalitsune Kalitsune May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops I forgot to post this message

Copy link
Author

@Ulysse2211 Ulysse2211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, sorry for my mistake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Kalitsune Kalitsune Kalitsune requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /