-
-
Notifications
You must be signed in to change notification settings - Fork 313
Remove dependency on rimraf #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fs-extra was basically created to avoid having to install both mkdirp, rimraf etc, and is also already installed here, so we can avoid using both at the same time. This moves rimraf to devDependencies, since it's still conveniant for the local 'clean' and 'prepack' commands. At the same time, update to fs-extra 10.x, since it's lowest supported node version there is now still lower than the lowest supported version for patch-package, but has still introduced the option of using node's native fs.rm when available: https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md (fs-extra 11.x only works on node 14.14+, while patch-package currently supports all 14.x versions)
ZuBB
commented
Jun 5, 2024
just wanna add that rimraf throws a warn
npm WARN deprecated rimraf@2.7.1: Rimraf versions prior to v4 are no longer supported
Is this project still supported?
Looks like fs-extra's removeSync is recursive, so this should be the same 👍🏻
rakleed
commented
Jan 12, 2025
@orta could you please publish a new version with these changes?
niksy
commented
Jun 12, 2025
Are there any blockers for getting this released? The only one I could think of is this:
fs-extra 11.x only works on node 14.14+, while patch-package currently supports all 14.x versions
/cc @orta
fs-extra 11.x only works on node 14.14+
This part is fine, since I only updated it to 10.x for now due to that.
Kamahl19
commented
Jul 8, 2025
@orta could you please make a release? Thanks!
fs-extra was basically created to avoid having to install both mkdirp, rimraf etc, and is also already installed here, so we can avoid using both at the same time.
This moves rimraf to devDependencies, since it's still conveniant for the local 'clean' and 'prepack' commands.
At the same time, update to fs-extra 10.x, since it's lowest supported node version there is now still lower than the lowest supported version for patch-package, but has still introduced the option of using node's native fs.rm when available:
https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md
(fs-extra 11.x only works on node 14.14+, while patch-package currently supports all 14.x versions)