-
-
Notifications
You must be signed in to change notification settings - Fork 313
[Feat] Add --create-issue character limit check #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @ds300 , a PR review would be appreciated :)
Hey @ds300 , any update on this feature?
Hey @ds300, are there any other maintainers who could take a look? Communication seems to have been suddenly cut off. Are you still present?
@ds300 Hey so im cleaning my PRs I'm contributing around, any chance this can be reviewed again/merged to incorporate this feature in a new release? There hasn't been any new releases in a year
hey @orta any chance you could review this PR, please?
I think this is a good idea, lets have it in
Thanks so much @orta!
Fixes #328
This change adds a limit to the message sent to the GitHub create issue URL to avoid URL too long errors.
If the diff contents exceed 300 characters (this was chosen arbitrarily), the diff contents are replaced with a comment message replacement, and the console outputs the complete PR diff contents and instructs the user to copy/paste the diff into the PR description manually.
(The old PR was closed automatically when I merged the OG repo into the forked repo)