-
-
Notifications
You must be signed in to change notification settings - Fork 313
Support yarn-path config option in yarnrc #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if path.resolve would be better than path.join in case the path has something like ../
I merged some upstream changes related to the yarnk lockfile which caused some conflicts, and the changes aren't quite simple enough that I'd feel comfortable using the web editor for the conflicts.
I think this is something we should get merged, so if you'd like to rebase, I'm happy to get it in. I think I also agree with @NMinhNguyen on using resolve too (but I'm not 100%)
Fixes #347