Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix: normalize version for npm ci #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ds300 merged 1 commit into ds300:master from teppeis:fix-npm-ci
Feb 7, 2019
Merged

Conversation

Copy link
Contributor

@teppeis teppeis commented Feb 5, 2019 •
edited
Loading

npm install and creating a patch, then npm ci fails:

patch-package 6.0.2
Applying patches...
Warning: patch-package detected a patch file version mismatch
 Don't worry! This is probably fine. The patch was still applied
 successfully. Here's the deets:
 Patch file created for
 google-closure-library@20190121.0.0
 applied to
 google-closure-library@v20190121.0.0
 
 At path
 
 node_modules/google-closure-library

The original version of the package.json is v20190121.0.0.

This issue is caused by difference between behavior of npm install and npm ci.
npm install normalizes version in package.json of deps (v20190121.0.0 is changed to 20190121.0.0) but npm ci doesn't (just v20190121.0.0).

This PR normalizes the version with semver.

repro: https://github.com/teppeis/closure-library.d.ts

@teppeis teppeis changed the title (削除) Fix for npm ci (削除ここまで) (追記) Fix: normalize version for npm ci (追記ここまで) Feb 5, 2019
Copy link
Owner

ds300 commented Feb 7, 2019

thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /