scripts/synchronize_panes.sh (4)

19-25: Per-widget refresh override: good addition; add basic validation.

Current logic accepts any string; a non-numeric value will make sleep fail. Recommend validating and falling back to the global rate.

- RATE_OVERRIDE=$(get_tmux_option "@dracula-synchronize-panes-refresh-rate" "")
- if [[ -n "$RATE_OVERRIDE" ]]; then
- RATE="$RATE_OVERRIDE"
- fi
+ RATE_OVERRIDE=$(get_tmux_option "@dracula-synchronize-panes-refresh-rate" "")
+ if [[ -n "$RATE_OVERRIDE" ]]; then
+ # accept integers or decimals like 0.5; clamp to a sane minimum to avoid busy looping
+ if [[ "$RATE_OVERRIDE" =~ ^([0-9]+)(\.[0-9]+)?$ ]]; then
+ RATE="$RATE_OVERRIDE"
+ # optional clamp
+ (( $(awk "BEGIN{print ($RATE<0.1)}") )) && RATE=0.1
+ fi
+ fi

---

26-26: Boolean option parsing is case-sensitive.

You compare strictly to 'true'. Consider normalizing to lowercase to avoid surprises from users setting True/TRUE.

- synchronize_panes_auto_hide=$(get_tmux_option "@dracula-synchronize-panes-auto-hide" "false")
+ synchronize_panes_auto_hide=$(get_tmux_option "@dracula-synchronize-panes-auto-hide" "false")
+ synchronize_panes_auto_hide="${synchronize_panes_auto_hide,,}"

---

28-36: Confirm intended UX: label-only when on, nothing when off.

With auto-hide=true: you output only the label when sync is on, and nothing when it’s off. That matches "hide when off" but also removes the "on" suffix entirely. Confirm this is desired for consistency with other widgets.

You can reduce nesting and make behavior explicit:

- if [[ "$synchronize_panes_auto_hide" == 'true' ]]; then
- if [[ "$synchronize_panes_status" == 'on' ]]; then
- echo "$synchronize_panes_label"
- fi
- else
- echo "$synchronize_panes_label $synchronize_panes_status"
- fi
+ if [[ "$synchronize_panes_auto_hide" == 'true' && "$synchronize_panes_status" == 'off' ]]; then
+ : # hide
+ elif [[ "$synchronize_panes_auto_hide" == 'true' ]]; then
+ echo "$synchronize_panes_label"
+ else
+ echo "$synchronize_panes_label $synchronize_panes_status"
+ fi

---

38-38: Portability of fractional sleep.

Docs suggest "0.5"; fractional sleep is GNU/coreutils-friendly but may vary with BusyBox/older BSDs. Either document the requirement or guard with integer fallback.

Add a pre-check:

- sleep $RATE
+ if ! sleep "$RATE" 2>/dev/null; then
+ # fallback to nearest integer second
+ sleep "${RATE%.*}"
+ fi

docs/CONFIG.md (1)

815-821: Clarify behavior and constraints for new options.

• Spell out the exact behavior with auto-hide: when true, the widget shows only the label while sync is on, and hides entirely when off.
• Note that @dracula-synchronize-panes-refresh-rate overrides this widget only; it does not change @dracula-refresh-rate.
• Mention that boolean values are case-sensitive ('true'/'false').
• If you intend to support decimals (e.g., "0.5"), add a brief portability note that fractional sleep requires GNU/coreutils or compatible environments.

Proposed wording:

# synchronize-panes
...
Optional:
set -g @dracula-synchronize-panes-auto-hide true # when true: shows only the label while sync is on; hides the widget when sync is off
set -g @dracula-synchronize-panes-refresh-rate "0.5" # refresh rate for this widget only; does not affect @dracula-refresh-rate
# Note: values are case-sensitive; use 'true'/'false'. Fractional rates require a shell/coreutils that support fractional `sleep`.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro