-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Merge main to collection expression arguments #80751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CyrusNajmabadi
merged 296 commits into
dotnet:features/collection-expression-arguments
from
RikkiGibson:merge-main-to-collection-expression-arguments
Oct 17, 2025
Merged
Merge main to collection expression arguments #80751
CyrusNajmabadi
merged 296 commits into
dotnet:features/collection-expression-arguments
from
RikkiGibson:merge-main-to-collection-expression-arguments
Oct 17, 2025
+30,477
−7,554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable saving test dlls with environment variable This will help with investigations for runtime async and other areas where we simply want to get the exact assembly the compiler is producing under test. * Reuse existing infrastructure, remove unused method. * Clarify comment * Restore dump funcion
...001.1 (dotnet#80539) [main] Update dependencies from dotnet/arcade
* Reduce allocations in SourceText.ToString This method was using a PooledStringBuilder to do it's string buildup. When a PooledStringBuilder's underlying StringBuilder exceeeds 1024, it is no longer returned to the pool upon completion. SourceText.ToString results commonly exceeed 1024 characters. To better improve those cases, we can use string.Create directly to avoid the StringBuilder altogether. This accounts for about 0.6% of all allocations in the RoslynCodeAnalysisService process in the razor CompletionInCohosting speedometer test.
...ronment variable handling (dotnet#80498) * Initial plan * Fix thread safety issue in BuildServerConnection.TryCreateServer environment variable handling Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com> * Address review comments: Pass environment variables as parameter and fix CREF Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com> * Address review feedback: Fix whitespace, add DOTNET_ROOT(x86) test, improve logging Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com> * Apply suggestion from @jaredpar * Apply suggestion from @jaredpar * Apply suggestion from @jaredpar * Fix CreateProcess error: Add CREATE_UNICODE_ENVIRONMENT flag and fix blank lines Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com> * Improve comment: Explain why double null terminator is needed in environment block Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com> * Add explanatory comments per code review feedback Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com> * Fix: Clear DOTNET_ROOT_* variants to prevent inheritance on Linux Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com> * Update comment: Clarify that Windows API requires sorted environment variables Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com> Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com> Co-authored-by: Jared Parsons <jared@paranoidcoding.org> Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
...when file moved (dotnet#80535) * Add test demonstrating issue with document context in FBP * Fix GetTextDocumentAsync returning misc document preferentially over host document * fixes * Alternative approach: Remove from misc files and re-lookup document * Reword comment * Review feedback
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
...alse` operators are used
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
...ltiple locations include generated code" (dotnet#80713) * Revert "Update tests" This reverts commit 3a0fb03. * Revert "remove" This reverts commit c25cc57. * Revert "Add using" This reverts commit 62b83be. * Revert "Address code review feedback: inline variable, remove unused using, add WorkItem" This reverts commit 071da44. * Revert "Remove redundant inline comments from GetPreferredNonGeneratedLocationAsync" This reverts commit a150e3c. * Revert "Use IsGeneratedCodeAsync extension method to simplify code" This reverts commit abe9a83. * Revert "Add test for Go To Definition with partial user and generated code" This reverts commit 1317f68. * Revert "Implement Go To Definition preference for non-generated code" This reverts commit 4a4c3a3.
...ct references Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
...ction-expression-arguments
@dotnet-policy-service
dotnet-policy-service
bot
added
VSCode
Needs API Review
Needs to be reviewed by the API review council
labels
Oct 16, 2025
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.
CyrusNajmabadi
CyrusNajmabadi
approved these changes
Oct 16, 2025
@CyrusNajmabadi
CyrusNajmabadi
force-pushed
the
merge-main-to-collection-expression-arguments
branch
from
October 16, 2025 22:40
70c5f0e
to
010bea0
Compare
@CyrusNajmabadi
CyrusNajmabadi
merged commit Oct 17, 2025
72a7afe
into
dotnet:features/collection-expression-arguments
27 of 28 checks passed
@RikkiGibson
RikkiGibson
deleted the
merge-main-to-collection-expression-arguments
branch
October 17, 2025 00:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CyrusNajmabadi for review. AllInOne will likely have failures, could you please jump in and update failing tests within reason.
Conflict resolutions in 0a8b77e.