Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Merge main to collection expression arguments #80751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Member

@RikkiGibson RikkiGibson commented Oct 16, 2025

@CyrusNajmabadi for review. AllInOne will likely have failures, could you please jump in and update failing tests within reason.
Conflict resolutions in 0a8b77e.

CyrusNajmabadi and others added 30 commits October 1, 2025 16:54
* Enable saving test dlls with environment variable
This will help with investigations for runtime async and other areas where we simply want to get the exact assembly the compiler is producing under test.
* Reuse existing infrastructure, remove unused method.
* Clarify comment
* Restore dump funcion
* Reduce allocations in SourceText.ToString
This method was using a PooledStringBuilder to do it's string buildup. When a PooledStringBuilder's underlying StringBuilder exceeeds 1024, it is no longer returned to the pool upon completion. SourceText.ToString results commonly exceeed 1024 characters. To better improve those cases, we can use string.Create directly to avoid the StringBuilder altogether.
This accounts for about 0.6% of all allocations in the RoslynCodeAnalysisService process in the razor CompletionInCohosting speedometer test.
...ronment variable handling (dotnet#80498)
* Initial plan
* Fix thread safety issue in BuildServerConnection.TryCreateServer environment variable handling
Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>
* Address review comments: Pass environment variables as parameter and fix CREF
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
* Address review feedback: Fix whitespace, add DOTNET_ROOT(x86) test, improve logging
Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>
* Apply suggestion from @jaredpar
* Apply suggestion from @jaredpar
* Apply suggestion from @jaredpar
* Fix CreateProcess error: Add CREATE_UNICODE_ENVIRONMENT flag and fix blank lines
Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>
* Improve comment: Explain why double null terminator is needed in environment block
Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>
* Add explanatory comments per code review feedback
Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
* Fix: Clear DOTNET_ROOT_* variants to prevent inheritance on Linux
Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
* Update comment: Clarify that Windows API requires sorted environment variables
Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>
Co-authored-by: JoeRobich <611219+JoeRobich@users.noreply.github.com>
Co-authored-by: Jared Parsons <jared@paranoidcoding.org>
Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
DoctorKrolic and others added 17 commits October 14, 2025 08:42
...when file moved (dotnet#80535)
* Add test demonstrating issue with document context in FBP
* Fix GetTextDocumentAsync returning misc document preferentially over host document
* fixes
* Alternative approach: Remove from misc files and re-lookup document
* Reword comment
* Review feedback
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
...ltiple locations include generated code" (dotnet#80713)
* Revert "Update tests"
This reverts commit 3a0fb03.
* Revert "remove"
This reverts commit c25cc57.
* Revert "Add using"
This reverts commit 62b83be.
* Revert "Address code review feedback: inline variable, remove unused using, add WorkItem"
This reverts commit 071da44.
* Revert "Remove redundant inline comments from GetPreferredNonGeneratedLocationAsync"
This reverts commit a150e3c.
* Revert "Use IsGeneratedCodeAsync extension method to simplify code"
This reverts commit abe9a83.
* Revert "Add test for Go To Definition with partial user and generated code"
This reverts commit 1317f68.
* Revert "Implement Go To Definition preference for non-generated code"
This reverts commit 4a4c3a3.
...ct references
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
@dotnet-policy-service dotnet-policy-service bot added VSCode Needs API Review Needs to be reviewed by the API review council labels Oct 16, 2025
Copy link
Contributor

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

@CyrusNajmabadi CyrusNajmabadi force-pushed the merge-main-to-collection-expression-arguments branch from 70c5f0e to 010bea0 Compare October 16, 2025 22:40
@CyrusNajmabadi CyrusNajmabadi merged commit 72a7afe into dotnet:features/collection-expression-arguments Oct 17, 2025
27 of 28 checks passed
@RikkiGibson RikkiGibson deleted the merge-main-to-collection-expression-arguments branch October 17, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

No one assigned

Labels

Needs API Review Needs to be reviewed by the API review council VSCode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /