Summary

Fixes #60698

This PR adds support for renaming files that follow the Outer.Inner.cs naming convention when renaming nested types. Previously, when renaming a nested type in a file named using this convention, the IDE did not offer to rename the file. This is a common pattern used throughout the Roslyn codebase and in many .NET projects for organizing nested types.

Problem

When you have a file like Outer.Inner.cs containing:

partial class Outer
{
 class Inner {}
}

And you invoke rename on the Inner symbol, the rename dialog did not offer to rename the file. Similarly, renaming Outer would not suggest updating the filename.

Solution

This PR enhances the rename infrastructure to:

1. Detect nested type patterns - Recognize when a type's containment hierarchy matches a document name (e.g., type Inner inside Outer matches file Outer.Inner.cs)
2. Support multi-level nesting - Handle files like A.B.C.cs for three or more levels of nesting
3. Generate correct new names - When renaming any type in the hierarchy, produce the appropriate new filename

Examples

Renaming the inner type:

• File: Outer.Inner.cs → Outer.Foo.cs
• Code: class Inner → class Foo

Renaming the outer type:

• File: Outer.Inner.cs → Bar.Inner.cs
• Code: class Outer → class Bar

Multi-level nesting:

• File: A.B.C.cs → A.X.C.cs
• Code: class B → class X (middle type renamed)

Implementation Details

WorkspacePathUtilities.cs

Added three new methods to support nested type matching:

• SymbolMatchesDocumentName() - Checks if a symbol's full type hierarchy matches the document name pattern
• GetTypeHierarchy() - Extracts the containment chain from outermost to innermost type
• GetNewDocumentNameForSymbolRename() - Generates the new filename when a type in the hierarchy is renamed

AbstractEditorInlineRenameService.SymbolRenameInfo.cs

Enhanced GetFileRenameInfo() to check for nested type patterns in addition to simple type names, returning InlineRenameFileRenameInfo.Allowed when a match is found.

Renamer.RenameSymbolDocumentAction.cs

Updated GetMatchingTypeDeclarationAsync() and AnalyzeAsync() to find and match nested types with document names. Optimized to only create semantic models when the document name contains dots (indicating potential nested types).

Testing

Added six comprehensive test cases in CSharpRenamerTests.cs covering:

• Renaming inner types
• Renaming outer types
• Three-level nesting
• Renaming middle types in hierarchies
• Edge cases (non-matching names, types with namespaces)

Technical Considerations

• Performance: Fast path for simple types (no semantic model needed). Semantic model only created when document name suggests nested types.
• Compatibility: Case-insensitive matching maintains existing behavior. Works across all target frameworks (netstandard2.0, net8.0, net9.0).
• Symbol comparison: Uses SymbolEqualityComparer.Default for proper symbol equality checks.
• No breaking changes: Existing simple type rename behavior is preserved.

Fixes #60054

💬 Share your feedback on Copilot coding agent for the chance to win a 200ドル gift card! Click here to start the survey.