-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix SemanticModel.GetTypeInfo to return type information for ObjectCreationExpression.Type #80721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
+210
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...on.Type in C# and VB Co-authored-by: jcouv <12466233+jcouv@users.noreply.github.com>
@Copilot
Copilot
AI
changed the title
(削除) [WIP] Fix GetTypeInfo returning null Type for ObjectCreationExpressionSyntax (削除ここまで)
(追記) Fix SemanticModel.GetTypeInfo to return type information for ObjectCreationExpression.Type (追記ここまで)
Oct 14, 2025
Copilot finished work on behalf of
jcouv
October 14, 2025 21:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #75147 (VB) and the related C# issue
Problem
SemanticModel.GetTypeInfo()
was returning nullType
when called on theType
property of anObjectCreationExpressionSyntax
, even thoughGetSymbolInfo()
correctly returned the type symbol:This behavior was inconsistent - the Type node is in a "type-only context" (confirmed by
SyntaxFacts.IsInTypeOnlyContext
returning true), and other type-only contexts correctly return type information.Solution
C# Changes
Removed the explicit check in
CSharpSemanticModel.GetTypeInfoForNode()
that was blocking type information from being returned forObjectCreationExpressionSyntax.Type
nodes. The check dates back to the early days of Roslyn but there was no clear reason for this restriction.Visual Basic Changes
SemanticModel.GetTypeInfoForNode()
CanGetSemanticInfo()
to allow semantic information retrieval for the Type node of ObjectCreationExpression even when marked asIsMissing
New MyClass()
) asIsMissing
, while qualified types (e.g.,New N.MyClass()
) are not marked as missingTesting
Original prompt
Fixes #78783
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.