-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Adds a custom exporter option on command line args #2461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It doesn't make sense to have the RegisterCustomExporter function if you're just going to create it from the type and ignore the registered name. I like being able to use it from the type, but it should also work from the registered name.
Also, the command line option should support multiple values (like --runtimes). And I would prefer --exporters
[Edit] I see --exporters already exists for built-in exporters. Just expand it to support custom types.
I updated the PR based on the comments. In this change, a custom exporter can be added to the existing exporters collection.
If the exporter name is not found in the default list, then it tries to create an exporter from the argument as it will be considered to be a type name using the assembly name.
It is still in progress, let me know what do you think of this approach.
LGTM, unsure if we do want to support registering custom names (to be able to use simplified names as well as full assembly-qualified types). What do you think @adamsitnik?
Fix #1967
This code adds the ability to include a custom exporter from command line arguments.
The user can use the option --customExporter "{assembly-qualified name of exporter}" and it will load the exporter into the config.
Please let me know your thoughts on this approach.
Thank you.