Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Quantize QuestionAnswering models #1581

Open
bgawrych wants to merge 10 commits into dmlc:master
base: master
Choose a base branch
Loading
from bgawrych:quantize_nlp_v2

Conversation

Copy link

@bgawrych bgawrych commented Oct 6, 2021

Description

This PR enables quantization on question answering scripts.
Added custom calibration collector to avoid significant accuracy drop

leezu reacted with thumbs up emoji
@bgawrych bgawrych requested a review from a team as a code owner October 6, 2021 12:03
Copy link

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

github-actions bot commented Oct 6, 2021

answerable_logits
"""
backbone_net = self.backbone
if self.quantized:
Copy link

@anko-intel anko-intel Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.quantized:
if self.quantized_bacboneisnotNone:

end remove quantized ?

Copy link
Author

@bgawrych bgawrych Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but I remained this quantized flag as switch on/off of quantized model - not sure if it is really usable. What do you think?

Copy link

@anko-intel anko-intel Oct 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be not usable for me.

Copy link

github-actions bot commented Oct 8, 2021

Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@anko-intel anko-intel anko-intel approved these changes

@bartekkuncer bartekkuncer bartekkuncer approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /