This repository was archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 529
[Bug][Fix][WIP] Fix pre-layernormalization in Transformer #1488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sxjscience
sxjscience
changed the title
(削除) [Bug][Fix] Fix pre-layernormalization in Transformer (削除ここまで)
(追記) [Bug][Fix][WIP] Fix pre-layernormalization in Transformer (追記ここまで)
Jan 18, 2021
Codecov Report
@@ Coverage Diff @@ ## master #1488 +/- ## ========================================== + Coverage 81.98% 85.19% +3.21% ========================================== Files 52 52 Lines 6909 6822 -87 ========================================== + Hits 5664 5812 +148 + Misses 1245 1010 -235
Continue to review full report at Codecov.
|
Looks good— it seems all issues related to pre-norm and skip connection have been fixed.
The documentation website for preview: http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR1488/fix_pre_ln/index.html
I noticed that the performance becomes worse after I changed the implementation. Still investigating the issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the additional of the residual connection. The previous implementation was not correct. I'm rerunning the Transformer-Big-pre-ln experiment.
@yongyi-wu
Checklist
Essentials
Changes
Comments
cc @dmlc/gluon-nlp-team