This repository was archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 529
[Refactor]Add a switch for attention to return an unnormalized weight matrix. Move _get_attention_cell function position #1007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #1007 +/- ## =========================================== - Coverage 89.93% 75.39% -14.55% =========================================== Files 67 67 Lines 6340 6344 +4 =========================================== - Hits 5702 4783 -919 - Misses 638 1561 +923
|
Job PR-1007/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1007/1/index.html
Job PR-1007/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1007/2/index.html
Job PR-1007/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1007/3/index.html
@leezu Okay, I'll take a look, but the follow-up to tinybert may not be too fast, because I'm a little busy right now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the option for attention to return an unnormalized weight matrix.
This will be used for tinybert training.
Moved the position of the
_get_attention_cellfunction fromseq2seq_encoder_decodertoattention_cell,which I think makes more sense.Checklist
Essentials
Changes
Comments
cc @dmlc/gluon-nlp-team