This repository was archived by the owner on Dec 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
GHCJS support added #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dmjio
commented
Apr 22, 2015
Fantastic! Absolutely we'll support ghcjs.
Owner
dmjio
commented
Apr 22, 2015
It's now on hackage
Contributor
Author
manyoo
commented
Apr 22, 2015
Awesome! Will continue improving the code. Thanks for the great library. :)
Owner
dmjio
commented
Apr 22, 2015
Of course, and thank you for the great work!
On Wed, Apr 22, 2015 at 5:16 AM, Eric Wong notifications@github.com wrote:
Awesome! Will continue improving the code. Thanks for the great library. :)
—
Reply to this email directly or view it on GitHub
#14 (comment).
Cell: 1.630.740.8204
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if you're interested in supporting GHCJS. I'm planning on writing a small web app with GHCJS for hacker news and found your library before writing a new one. Although the library is GHC code but it's really easy to port. I just replace the functions in Client.hs with FFI to Javascript and use XMLHttpRequest directly, instead of using the network and open ssl libraries. I also bump the version number to 0.4.0.0 so it's easier for users to distinguish.