-
Notifications
You must be signed in to change notification settings - Fork 392
Removes call to SetDefaultScheme, which is not thread safe. #2993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs canceled.
|
@zerbitx
zerbitx
force-pushed
the
DSP-137
branch
from
August 19, 2025 23:40
fdd9d4f to
4e20ac7
Compare
Signed-off-by: Ryan Swanson <ryan.swanson@loft.sh>
@zerbitx
zerbitx
force-pushed
the
DSP-137
branch
from
August 19, 2025 23:43
4e20ac7 to
9c52741
Compare
@zerbitx
zerbitx
requested review from
FabianKramm and
LukasGentele
as code owners
August 20, 2025 00:04
@zerbitx
zerbitx
requested review from
lizardruss
and removed request for
FabianKramm and
LukasGentele
August 20, 2025 00:04
lizardruss
lizardruss
approved these changes
Aug 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #DSP-137
fixes #2989
See: here