-
Notifications
You must be signed in to change notification settings - Fork 392
feat(localRegistry): expose pod resources #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for devspace-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bumps [@babel/runtime-corejs3](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime-corejs3) from 7.22.5 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime-corejs3) --- updated-dependencies: - dependency-name: "@babel/runtime-corejs3" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
e59a093 to
4102245
Compare
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
deniseschannon
commented
May 30, 2025
Before we review, would you mind looking at the errors from the failed check for Lint?
https://github.com/devspace-sh/devspace/actions/runs/15261087358/job/43202271440?pr=2964
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
30e1bc1 to
9fc56c1
Compare
Before we review, would you mind looking at the errors from the failed check for Lint?
https://github.com/devspace-sh/devspace/actions/runs/15261087358/job/43202271440?pr=2964
Thanks for the heads up!
I removed those two unused fields, I had to guess a bit because I couldn't easily run the linter locally.
Hopefully that was all :)
Hello!
I don't know exactly why there is a failing test, doesn't seem related to changes in the PR.
Is there something I could do?
Hello!
I don't know exactly why there is a failing test, doesn't seem related to changes in the PR.
Is there something I could do?
It looks like this was a temporary failure. Could you also rebase your branch against main and push those changes? That will re-run the actions and hopefully they will work this time. fwiw, there's usually a button in GH to re-run, but I don't have that available right now.
Done!
Let's see if pipelines collaborate :)
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)No issue.
Please provide a short message that should be published in the DevSpace release notes
Exposed in the
localRegistryconfiguration resources and annotations of the created Pods.What else do we need to know?
I am not very familiar with go or this codebase, if you have any suggestions please feel free!