Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update the types to remove typing issues around uplot #10204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hkang1 wants to merge 1 commit into main
base: main
Choose a base branch
Loading
from uplot-type-updates

Conversation

Copy link
Contributor

@hkang1 hkang1 commented Nov 13, 2024
edited
Loading

Ticket

N/A

Description

This is not necessarily needed for our current given snapshot of uplot version but if we use the newer uplot versions, this PR will be needed.

The updated uPlot also now supports TypedArray for data instead of just number[], so wrapping the data with Array.from() will normalize the data to be number[].

Test Plan

  • ensure npm run lint passes
  • ensure npm run build passes

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Nov 13, 2024
edited
Loading

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 8c53919
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6734e783cf07fe00088fae6e
😎 Deploy Preview https://deploy-preview-10204--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hkang1 hkang1 marked this pull request as ready for review November 14, 2024 16:04
@hkang1 hkang1 requested a review from a team as a code owner November 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnkim-det johnkim-det Awaiting requested review from johnkim-det johnkim-det is a code owner automatically assigned from determined-ai/web

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /