-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add kwarg checker #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## main #33 +/- ## ========================================== - Coverage 95.87% 90.81% -5.06% ========================================== Files 12 13 +1 Lines 388 490 +102 Branches 62 89 +27 ========================================== + Hits 372 445 +73 - Misses 12 35 +23 - Partials 4 10 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR implements a pseudo-static type checker that takes a given dictionary to instantiate a given class and checks if it is correctly formatted. It raises an exception if it does not suffice.
This will be obviously useful for complex classes like PyKEEN models
DON'T MERGE WITHOUT 100% COVERAGE
finally, a proper opportunity to ensure this thing, because I basically just wrote a static type checker and i'm sure there's tons of stuff missing