-
Notifications
You must be signed in to change notification settings - Fork 932
[KIP-848] Tests for changes in DescribeConsumerGroups #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Tests for the DescribeConsumerGroups API have been updated to handle and verify the new ConsumerGroupType field for both classic and consumer protocols, and obsolete skip logic has been removed.
- Added
ConsumerGroupTypeimport and updatedconsume_messagesto accept agroup_protocolparameter. - Expanded
verify_describe_groupsto assertdesc.typefor both classic and consumer group protocols. - Removed the conditional skip for consumer protocol tests.
Copilot
AI
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra space before the colon in the if statement to follow style guidelines (e.g., PEP8).
Copilot
AI
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The test logic for classic and consumer group protocols is nearly identical; consider refactoring into a parameterized helper or loop to reduce duplication.
Copilot
AI
May 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are trailing spaces at the end of this line; consider removing them to clean up formatting.
c7e0997 to
f370a0b
Compare
Analysis Details
0 Issues
- Bug 0 Bugs
- Vulnerability 0 Vulnerabilities
- Code Smell 0 Code Smells
Coverage and Duplications
- Coverage No coverage information (66.00% Estimated after merge)
- Duplications No duplication information (5.20% Estimated after merge)
Project ID: confluent-kafka-python
Modified test for changes in DescribeConsumerGroups api