-
-
Notifications
You must be signed in to change notification settings - Fork 349
fix: condition on the creation of the kms key #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @schniber! 👋
Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.
Make sure that this PR clearly explains:
- the problem being solved
- the best way a reviewer and you can test your changes
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.
The following ChatOps commands are supported:
/help
: notifies a maintainer to help you out
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.
This message was generated automatically. You are welcome to improve it.
@npalm : Hey, is it possible to peer review this ?
Happy to iterate based on your inputs.
Bests.
meniluca
commented
Jun 17, 2025
We are also impacted by #1278 and looking forward to updating the runner to the latest version.
This change is now incompatible for those guys using a customer managed key. The module can be updated without setting the new variable to true
resulting in an outage, I guess or at least using the wrong keys to encrypt the resources.
Not sure how this can be solved.
Hey @kayman-mk I tested this PR with both options and it works.
Can you please elaborate a bit more on your last comment ?
Thanks a lot !
Bests.
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.
Description
this PR fixes #1278
Note: The whole PR is used as commit message.
Migrations required
No
Verification
I did deploy this module with both options, i.e. enable_managed_kms_key = true and enable_managed_kms_key = false to validate the fix