Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updated Next.js to v13 #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toniewypada wants to merge 4 commits into next
base: next
Choose a base branch
Loading
from PLAT-10092-update-next-js-example-to-v-13-1958

Conversation

Copy link

@toniewypada toniewypada commented Oct 27, 2023

Update Next.JS app to v13
Tested all scenarios which should work in local environment, all worked fine.

Changeset

Dependencies are updated to the current version

Testing

Test scenarios are included in Next.JS example readme

Tested all scenarios which should work in local environment, all worked fine.
Copy link

github-actions bot commented Oct 27, 2023
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 45.89 kB 13.78 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 38671d7

Copy link
Contributor

mclack commented Oct 27, 2023

I've tried all scenarios with the update, and noticed some unexpected behaviour. The README says we expect API scenario 2 and Client scenario 1 to fail, but I saw Client 1 works and API 2 works. However, I was unable to get anything for API scenario 1.

I think it might be worth quickly checking all scenarios again with Next.js v13.5.4, and making sure the behaviour you see matches up with what we say in the README. Is this a direct result of changing the version of Next, or do you see the same behaviour in the old example app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mclack mclack Awaiting requested review from mclack

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /