-
Notifications
You must be signed in to change notification settings - Fork 670
Parser.consume #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser.consume #2913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking API change...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and one that is overdue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meaning of the return value used to be different from what it is now. We changed it because of user requests. If we change it again, then we are breaking those users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meaning of the return value used to be different from what it is now. We changed it because of user requests. If we change it again, then we are breaking those users.
Wasn't that for async_read_some? #1942
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. I think you should decide if this is a good change. And if not, what else we might do (if anything).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## develop #2913 +/- ## =========================================== - Coverage 93.09% 93.08% -0.02% =========================================== Files 177 177 Lines 13709 13773 +64 =========================================== + Hits 12763 12821 +58 - Misses 946 952 +6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
I want to write a stream API for http.
I will also need a buffer to reset a previously returned buffer from a body-writer.