-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(datastore): prevent version cross-contamination between different model types #14570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anivar
wants to merge
1
commit into
aws-amplify:main
from
anivar:fix/datastore-save-version-conflict-13412
Open
fix(datastore): prevent version cross-contamination between different model types #14570
anivar
wants to merge
1
commit into
aws-amplify:main
from
anivar:fix/datastore-save-version-conflict-13412
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... model types Fixes issue where DataStore.save() operations on different model types with the same ID would incorrectly share _version values, causing subsequent mutations to fail with version conflicts. The syncOutboxVersionsOnDequeue method now filters by model type in addition to modelId to ensure version synchronization only occurs within the same model type. Fixes aws-amplify#13412
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes issue where DataStore.save() operations on different model types with the same ID would incorrectly share _version values, causing subsequent mutations to fail with version conflicts.
Resolves #13412
Description
The syncOutboxVersionsOnDequeue method was querying mutations by modelId only, without filtering by model type. This caused version synchronization to occur across different model types that happened to share the same primary key value.
This is a minimal fix with 1 line of actual code change that solves a critical production issue affecting multi-model applications.
Problem
When saving different model types consecutively that have the same ID:
Root Cause
The predicate in syncOutboxVersionsOnDequeue only filtered by modelId without considering model type, causing version contamination between different models.
Solution
Added model type filter to the predicate to ensure version synchronization only occurs within the same model type:
Testing
Added test case "Should NOT sync the _version across different model types with the same ID" to verify the fix prevents version cross-contamination while preserving legitimate version synchronization within the same model type.
Changes
Fixes #13412