feat(predictions):adds ssml support to polly integration #10007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

elvinrowe wants to merge 1 commit into aws-amplify:main

from elvinrowe:predictions/feat-ssml-polly

Open

feat(predictions):adds ssml support to polly integration #10007

elvinrowe wants to merge 1 commit into aws-amplify:main from elvinrowe:predictions/feat-ssml-polly

+6 −4

Conversation

elvinrowe

Copy link

@elvinrowe elvinrowe commented Jun 19, 2022

Description of changes

Adds optional textType property to TextToSpeechInput interface that can be set to either 'text' or 'ssml'.
Updated the SynthesizeSpeech call so the TextType can be set by the textType property. TextType defaults to 'text' if textType property is undefined maintaining current functionality.

Issue #, if available

6075

Description of how you validated changes

Ran change through a sample app

Checklist

PR description included
yarn test passes
Tests are changed or added
Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@elvinrowe


 feat(predictions):adds ssml support to polly integ

c6d02f4

@elvinrowe elvinrowe requested review from elorzafe and stocaaro as code owners

June 19, 2022 11:07

@codecov-commenter

Copy link

codecov-commenter commented Jun 19, 2022 •

edited

Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.61%. Comparing base (eb73ad7) to head (c6d02f4).
⚠️ Report is 2932 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

@@ Coverage Diff @@
## main #10007 +/- ##
==========================================
- Coverage 83.62% 83.61% -0.02% 
==========================================
 Files 253 253 
 Lines 18261 18262 +1 
 Branches 3918 3919 +1 
==========================================
- Hits 15271 15270 -1 
- Misses 2898 2900 +2 
 Partials 92 92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.