-
-
Notifications
You must be signed in to change notification settings - Fork 116
Only reset abortcontroller ref if captured instance is same as ref #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EtherZa
wants to merge
1
commit into
ava:master
from
EtherZa:bug/302-superseded-abortcontroller-ref-undefined
Open
Only reset abortcontroller ref if captured instance is same as ref #393
EtherZa
wants to merge
1
commit into
ava:master
from
EtherZa:bug/302-superseded-abortcontroller-ref-undefined
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshollie
commented
Sep 17, 2024
This solves an issue we were experiencing with this library. @alex-cory I'm sure others would benefit from merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
#302 describes a race condition where an aborted request resets the abort controller ref even though a subsequent request has been issued and already replaced the ref.
Code sandbox: https://codesandbox.io/p/sandbox/react-hooks-usefetch-forked-xsdrhl?file=%2Fsrc%2Findex.js
Steps to reproduce:
Cause:
On completing a request (normal or aborted), the captured AbortController ref (controller.current) is set to undefined in the finally block. If a request is aborted and then immediately resubmitted, this results in a race condition where:
Resolution:
Only set the controller ref to undefined if the ref is still set to the current controller instance
Note:
This PR makes no attempt to resolve the underlying race condition. It proposes a solution to allow for the last issued request to be aborted while potentially managing the race condition through other means.